[
https://issues.apache.org/jira/browse/HDFS-7990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382547#comment-14382547
]
Hadoop QA commented on HDFS-7990:
---------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12707526/HDFS-7990.patch
against trunk revision 2228456.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs.
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/10076//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HDFS-Build/10076//console
This message is automatically generated.
> IBR delete ack should not be delayed
> ------------------------------------
>
> Key: HDFS-7990
> URL: https://issues.apache.org/jira/browse/HDFS-7990
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 2.0.0-alpha
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HDFS-7990.patch
>
>
> HDFS-395 added the incremental BR feature. A concern was avoiding a race
> condition with ack-ing block invalidates followed by the directory scanner
> re-adding the block before the async delete service removes the block,
> possibly resulting in a full BR that includes the previously delete ack-ed
> block.
> The solution was to batch & delay block deletion acks via a hardcoded
> interval of 100 * heartbeat interval (default: 5min). The delay isn't
> required:
> # The {{FSDatasetSpi}} tracks blocks pending deletions precisely so the
> scanner won't re-add the block to the volume map
> # Block receiving, received, and deleted go into the same pending report. A
> block received event will trigger an immediate IBR which includes the
> deletion acks. Ie. The delay is meaningless for all but a quiescent cluster
> # Failing to promptly report deleted blocks on a quiescent cluster prevents
> the NN from updating the block maps to remove the locations
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
