[
https://issues.apache.org/jira/browse/HDFS-8003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14384195#comment-14384195
]
Allen Wittenauer edited comment on HDFS-8003 at 3/27/15 5:24 PM:
-----------------------------------------------------------------
To be more precise, there are a bunch of problems here, but those aren't them:
* CLASSPATH hasn't been exported yet so that needs to happen
* HADOOP_OPTS has *already* been finalized, so adding other option strings
breaks the contract
There are a bunch of things we *could* do here:
a) Just put the necessary disable lines in shut shellcheck up
b) run the equivalent hdfs commands instead of pretending that our environment
is correct and running the classes directly
B is probably the best fix. But frankly, this seems like we're working around
a problem in the Java code by patching it at the shell level.
was (Author: aw):
To be more precise, there are a bunch of problems here, but those aren't them:
* CLASSPATH hasn't been exported yet so that needs to happen
* HADOOP_OPS has *already* been finalized, so adding other option strings
breaks the contract
There are a bunch of things we *could* do here:
a) Just put the necessary disable lines in shut shellcheck up
b) run the equivalent hdfs commands instead of pretending that our environment
is correct and running the classes directly
B is probably the best fix. But frankly, this seems like we're working around
a problem in the Java code by patching it at the shell level.
> hdfs has 3 new shellcheck warnings
> ----------------------------------
>
> Key: HDFS-8003
> URL: https://issues.apache.org/jira/browse/HDFS-8003
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Allen Wittenauer
> Assignee: Brahma Reddy Battula
>
> HDFS-6353 introduced three new shell check warnings due to an unprotected
> ${HADOOP_OPTS}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
