[
https://issues.apache.org/jira/browse/HDFS-7907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385151#comment-14385151
]
Zhe Zhang commented on HDFS-7907:
---------------------------------
I just finished reviewing the patch. It looks good overall. I thought more
about the block ID translation logic and feel that handling it in DN is not
very robust. So please ignore that part of comment.
More detailed review:
# The signature change of {{blockHasEnoughRacks}}: is it because
{{requiredReplication}} has already been calculated before calling the function?
# Similarly, changing signature of {{removeStoredBlock}} is to avoid calling
{{getStoredBlock}} again?
# It seems {{storage}} is only used to get {{dn}}? Should we change the
signature?
{code}
- private void addToExcessReplicate(DatanodeInfo dn, Block block) {
+ private void addToExcessReplicate(DatanodeStorageInfo storage,
+ BlockInfo storedBlock) {
assert namesystem.hasWriteLock();
- LightWeightLinkedSet<Block> excessBlocks =
excessReplicateMap.get(dn.getDatanodeUuid());
+ DatanodeInfo dn = storage.getDatanodeDescriptor();
{code}
# The patch seems more about over replication / invalidation than about decomm
manager? If so maybe we should update the JIRA description?
> Update DecommissionManager to support striped blocks
> ----------------------------------------------------
>
> Key: HDFS-7907
> URL: https://issues.apache.org/jira/browse/HDFS-7907
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-7907.000.patch
>
>
> With recent changes from HDFS-7411, we need to update DecommissionManager to
> support striped blocks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
