[
https://issues.apache.org/jira/browse/HDFS-7980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385190#comment-14385190
]
Walter Su commented on HDFS-7980:
---------------------------------
I trying to write a test covering the if statement.
{code}
if (storageInfo.getBlockReportCount() == 0) {
// The first block report can be processed a lot more efficiently than
// ordinary block reports. This shortens restart times.
processFirstBlockReport(storageInfo, newReport);
} else {
invalidatedBlocks = processReport(storageInfo, newReport);
}
storageInfo.receivedBlockReport();
{code}
At first, I try to use {{Mockito.verify(..)}} to count how many times
{{BlockManager.processFirstBlockReport(..)}} being called. So I can write a
test that make sure {{processFirstBlockReport(..)}} be called only once during
DN register. But Mockito doesn't support mock private method.
{{getBlockReportCount()}} is visible, but the result is too obviously, because
report count only added when {{receivedBlockReport()}} is called. I'm new in
testing. I'd appreciate any help.
> Incremental BlockReport will dramatically slow down the startup of a namenode
> ------------------------------------------------------------------------------
>
> Key: HDFS-7980
> URL: https://issues.apache.org/jira/browse/HDFS-7980
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Hui Zheng
> Assignee: Walter Su
> Attachments: HDFS-7980.001.patch
>
>
> In the current implementation the datanode will call the
> reportReceivedDeletedBlocks() method that is a IncrementalBlockReport before
> calling the bpNamenode.blockReport() method. So in a large(several thousands
> of datanodes) and busy cluster it will slow down(more than one hour) the
> startup of namenode.
> {code}
> List<DatanodeCommand> blockReport() throws IOException {
> // send block report if timer has expired.
> final long startTime = now();
> if (startTime - lastBlockReport <= dnConf.blockReportInterval) {
> return null;
> }
> final ArrayList<DatanodeCommand> cmds = new ArrayList<DatanodeCommand>();
> // Flush any block information that precedes the block report. Otherwise
> // we have a chance that we will miss the delHint information
> // or we will report an RBW replica after the BlockReport already reports
> // a FINALIZED one.
> reportReceivedDeletedBlocks();
> lastDeletedReport = startTime;
> .........
> // Send the reports to the NN.
> int numReportsSent = 0;
> int numRPCs = 0;
> boolean success = false;
> long brSendStartTime = now();
> try {
> if (totalBlockCount < dnConf.blockReportSplitThreshold) {
> // Below split threshold, send all reports in a single message.
> DatanodeCommand cmd = bpNamenode.blockReport(
> bpRegistration, bpos.getBlockPoolId(), reports);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
