[
https://issues.apache.org/jira/browse/HDFS-8005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387293#comment-14387293
]
Zhe Zhang commented on HDFS-8005:
---------------------------------
bq. HDFS-7742 has already removed this logic.
Right, that makes our job easier. Do you think we should just restore the
original {{chooseSourceDatanode}} code (before HDFS-7369), and just add a
separate function for striped blocks? Right now striped blocks are not using
much of the {{chooseSourceDatanodes}} logic anyway.
Other than that, the 001 patch looks good. Thanks Jing for the rev!
> Erasure Coding: simplify striped block recovery work computation and add tests
> ------------------------------------------------------------------------------
>
> Key: HDFS-8005
> URL: https://issues.apache.org/jira/browse/HDFS-8005
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Attachments: HDFS-8005.000.patch, HDFS-8005.000.patch,
> HDFS-8005.001.patch
>
>
> HDFS-7369 adds the functionality to distribute recovery work of striped
> blocks to datanodes. There are still some pending issues:
> # In {{BlockManager#chooseSourceNode}}, a node is added into
> {{healthyIndices}} without checking if its block is live and healthy
> # The test {{TestRecoverStripedBlcoks#testMissingStripedBlock}} has not
> tested striped blocks because the file is created before setting the storage
> policy
> # In {{computeRecoveryWorkForBlocks}}, instead of using
> {{BlockCollection#isStriped}}, we'd better use {{BlockInfo#isStriped}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
