[ 
https://issues.apache.org/jira/browse/HDFS-7944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387728#comment-14387728
 ] 

Haohui Mai commented on HDFS-7944:
----------------------------------

+1

> Minor cleanup of BlockPoolManager#getAllNamenodeThreads
> -------------------------------------------------------
>
>                 Key: HDFS-7944
>                 URL: https://issues.apache.org/jira/browse/HDFS-7944
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.6.0
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>            Priority: Minor
>         Attachments: HDFS-7944.01.patch, HDFS-7944.02.patch
>
>
> {{BlockPoolManager#getAllNamenodeThreads}} can avoid unnecessary list to 
> array conversion and vice versa by returning an unmodifiable list.
> Since NN addition/removal is relatively rare we can just use a 
> {{CopyOnWriteArrayList}} for concurrency.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to