[
https://issues.apache.org/jira/browse/HDFS-7888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388018#comment-14388018
]
Zhe Zhang commented on HDFS-7888:
---------------------------------
Thanks Bo! The patch looks good to me. All 3 changes are pretty clear and
straightforward. A few nits:
# An unnecessary change in import:
{code}
import java.util.concurrent.atomic.AtomicReference;
-
{code}
# Looks like the following line is too long?
{code}
+ dfsClient.getPathTraceScope(className.substring(0,
className.lastIndexOf('.') + 1)
{code}
Could you also post a trunk-based patch to trigger Jenkins? Thanks!
> Change DataStreamer/DFSOutputStream/DFSPacket for convenience of subclassing
> ----------------------------------------------------------------------------
>
> Key: HDFS-7888
> URL: https://issues.apache.org/jira/browse/HDFS-7888
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Li Bo
> Assignee: Li Bo
> Attachments: HDFS-7888-001.patch
>
>
> HDFS-7793 refactors class {{DFSOutputStream}} on trunk which makes
> {{DFSOutputStream}} a class without any inner classes. We want to subclass
> {{DFSOutputStream}} to support striping layout writing. This JIRA depends
> upon HDFS-7793 and tries to change DataStreamer/DFSOutputStream/DFSPacket for
> convenience of subclassing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
