[
https://issues.apache.org/jira/browse/HDFS-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388482#comment-14388482
]
Rakesh R commented on HDFS-7937:
--------------------------------
Thanks [~kaisasak], good number of unit test cases. I've few minor comments,
please see it.
# TestINodeFile#testBlockStripedTotalBlockCount, Do we need the below logic in
this testcase ?
{code}
+ INodeFile inf = createINodeFile(HdfsConstants.EC_STORAGE_POLICY_ID);
+ inf.addStripedBlocksFeature();
{code}
# Could you please do the assertion by reversing the {{actual}} and
{{expected}} arguments. I could see this kind of usage in many places, please
modify all such cases. For example,
case-1)
{code}
assertEquals(inf.getBlocks().length, 1);
can be written as :
assertEquals(1, inf.getBlocks().length);
{code}
Case-2)
{code}
assertEquals(blockInfoStriped.getTotalBlockNum(), 9);
can be written as :
assertEquals(9, blockInfoStriped.getTotalBlockNum());
{code}
> Erasure Coding: INodeFile quota computation unit tests
> ------------------------------------------------------
>
> Key: HDFS-7937
> URL: https://issues.apache.org/jira/browse/HDFS-7937
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Kai Sasaki
> Assignee: Kai Sasaki
> Priority: Minor
> Attachments: HDFS-7937.1.patch, HDFS-7937.2.patch
>
>
> Unit test for [HDFS-7826|https://issues.apache.org/jira/browse/HDFS-7826]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
