[ 
https://issues.apache.org/jira/browse/HDFS-8025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391332#comment-14391332
 ] 

Andrew Wang commented on HDFS-8025:
-----------------------------------

Hey Ming, thanks for working on this. Did you consider putting the new check in 
BlockManager#isNodeHealthyForDecommission? This is a better home for this check 
(since this does relate to node health), and I think it should be approximately 
as efficient since a node will have 0 blocks before its FBR.

It would also be good to add some logging for this case, since a perpetual 
complaint about decom is the lack of visibility as to why a node is stuck.

> Addendum for HDFS-3087
> ----------------------
>
>                 Key: HDFS-8025
>                 URL: https://issues.apache.org/jira/browse/HDFS-8025
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Ming Ma
>            Assignee: Ming Ma
>         Attachments: HDFS-8025.patch
>
>
> Per discussion with [~andrew.wang] on HDFS-7411, we should include HDFS-3087 
> and enhance the unit test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to