[
https://issues.apache.org/jira/browse/HDFS-7811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393972#comment-14393972
]
Hadoop QA commented on HDFS-7811:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12709097/HDFS-7811.04.patch
against trunk revision 16b74f9.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.TestEncryptionZonesWithKMS
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/10168//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HDFS-Build/10168//console
This message is automatically generated.
> Avoid recursive call getStoragePolicyID in INodeFile#computeQuotaUsage
> ----------------------------------------------------------------------
>
> Key: HDFS-7811
> URL: https://issues.apache.org/jira/browse/HDFS-7811
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Reporter: Xiaoyu Yao
> Assignee: Xiaoyu Yao
> Priority: Minor
> Attachments: HDFS-7811.00.patch, HDFS-7811.01.patch,
> HDFS-7811.02.patch, HDFS-7811.03.patch, HDFS-7811.04.patch
>
>
> This is a follow up based on comment from [~jingzhao] on HDFS-7723.
> I just noticed that INodeFile#computeQuotaUsage calls getStoragePolicyID to
> identify the storage policy id of the file. This may not be very efficient
> (especially when we're computing the quota usage of a directory) because
> getStoragePolicyID may recursively check the ancestral INode's storage
> policy. I think here an improvement can be passing the lowest parent
> directory's storage policy down while traversing the tree.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
