[ 
https://issues.apache.org/jira/browse/HDFS-7782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394101#comment-14394101
 ] 

Jing Zhao commented on HDFS-7782:
---------------------------------

The 006 patch looks good to me overall.

One issue I missed in the previous review is that the parameter {{start}} in 
{{fetchBlockByteRange}} and {{getFromOneDataNode}} should be the starting 
offset of that block, instead of file. Thus the corresponding calculation in 
both 005 and 006 patch need to be updated accordingly.

> Erasure coding: pread from files in striped layout
> --------------------------------------------------
>
>                 Key: HDFS-7782
>                 URL: https://issues.apache.org/jira/browse/HDFS-7782
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Li Bo
>            Assignee: Zhe Zhang
>         Attachments: HDFS-7782-000.patch, HDFS-7782-001.patch, 
> HDFS-7782-002.patch, HDFS-7782-003.patch, HDFS-7782-004.patch, 
> HDFS-7782-005.patch, HDFS-7782-006.patch
>
>
> If client wants to read a file, he is not necessary to know and handle what 
> layout the file is. This sub task adds logic to DFSInputStream to support 
> reading striping layout files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to