[ 
https://issues.apache.org/jira/browse/HDFS-8023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484751#comment-14484751
 ] 

Vinayakumar B commented on HDFS-8023:
-------------------------------------

bq. 2. To make the TODOs easy, I just opened HDFS-8074 so that you will just 
return the default schema. HDFS-8062 will further fill the left gaps. OK?
As of now, I have used directly "RS-6-3". this could be revisited once the 
HDFS-7859 is in.

bq. A minor. How about getEcInfo => getECInfo like you used convertECInfo?
done, but had to rename the variable {{ecInfo}} to {{ECInfo}} in 
ClientNamenodeProtocol.proto since that was autogenerated method.
bq. So if we could get the TODOs done I guess we could also have two tests for 
the two new APIs.
Added test.
bq. Maybe we can move ECInfo to the o.a.h.hdfs.protocol package?
Done
bq. The name "ECInfo" looks better to me compared with "ECZoneInfo" because it 
is used to tell the information of individual files/directories. We can make it 
independent with our design/implementation about how to specify the EC schema 
for files/directories.
Kept {{ECInfo}} as is. May be in future, if client wants to know the Zone level 
information, then {{ECInfo}} could include {{ECZoneInfo}} inside.
bq. getErasureCondingInfo --> getErasureCodingInfo
done
bq. Do we need to provide DatanodeProtocol#getErasureCodingInfo(ExtendedBlock)? 
Currently a DataNode cannot distinguish a contiguous block and a block that 
belongs to a striped block group. And for recovery, I guess we only need to 
include the ECSchema information in the corresponding recovery command?
Yes! you are right. As of now I also dont see the necessity. Will skip in this 
Jira. If required we can add it later.


> Erasure Coding: retrieve eraure coding policy and schema for a block or file 
> from NameNode
> ------------------------------------------------------------------------------------------
>
>                 Key: HDFS-8023
>                 URL: https://issues.apache.org/jira/browse/HDFS-8023
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Kai Zheng
>            Assignee: Vinayakumar B
>         Attachments: HDFS-8023-01.patch
>
>
> NameNode needs to provide RPC call for client, tool, or DataNode to retrieve 
> eraure coding policy and schema for a block or file from NameNode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to