[
https://issues.apache.org/jira/browse/HDFS-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486867#comment-14486867
]
Vinayakumar B commented on HDFS-8104:
-------------------------------------
Patch looks good.
I agree that fixing the {{testPlanReadPortions}} to suite default schema would
be tricky. Anyway it has to support multiple codecs of different sizes. Let 3
one of those.
One nit.
remote unused import in {{TestReadStripedFile}}
+1 after that
> Make hard-coded values consistent with the system default schema first before
> remove them
> -----------------------------------------------------------------------------------------
>
> Key: HDFS-8104
> URL: https://issues.apache.org/jira/browse/HDFS-8104
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Attachments: HDFS-8104-v1.patch
>
>
> It's not easy to remove the hard-coded values to use the system default
> schema. We may need several steps/issues to cover relevant aspects. First of
> all, let's make the hard-coded values consistent with the system default
> schema first. This might not so easy, as experimental test indicated, when
> change the following two lines, some tests then failed.
> {code}
> - public static final byte NUM_DATA_BLOCKS = 3;
> - public static final byte NUM_PARITY_BLOCKS = 2;
> + public static final byte NUM_DATA_BLOCKS = 6;
> + public static final byte NUM_PARITY_BLOCKS = 3;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
