[ 
https://issues.apache.org/jira/browse/HDFS-8101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487068#comment-14487068
 ] 

Hadoop QA commented on HDFS-8101:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12724161/HDFS-8101.1.patch.txt
  against trunk revision 9d8952f.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-hdfs-project/hadoop-hdfs.

Test results: 
https://builds.apache.org/job/PreCommit-HDFS-Build/10227//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HDFS-Build/10227//console

This message is automatically generated.

> DFSClient use of non-constant DFSConfigKeys pulls in WebHDFS classes at 
> runtime
> -------------------------------------------------------------------------------
>
>                 Key: HDFS-8101
>                 URL: https://issues.apache.org/jira/browse/HDFS-8101
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client
>    Affects Versions: 2.7.0
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Minor
>         Attachments: HDFS-8101.1.patch.txt
>
>
> Previously, all references to DFSConfigKeys in DFSClient were compile time 
> constants which meant that normal users of DFSClient wouldn't resolve 
> DFSConfigKeys at run time. As of HDFS-7718, DFSClient has a reference to a 
> member of DFSConfigKeys that isn't compile time constant 
> (DFS_CLIENT_KEY_PROVIDER_CACHE_EXPIRY_DEFAULT).
> Since the class must be resolved now, this particular member
> {code}
> public static final String  DFS_WEBHDFS_AUTHENTICATION_FILTER_DEFAULT = 
> AuthFilter.class.getName();
> {code}
> means that javax.servlet.Filter needs to be on the classpath.
> javax-servlet-api is one of the properly listed dependencies for HDFS, 
> however if we replace {{AuthFilter.class.getName()}} with the equivalent 
> String literal then downstream folks can avoid including it while maintaining 
> compatibility.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to