[
https://issues.apache.org/jira/browse/HDFS-8133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492964#comment-14492964
]
Hadoop QA commented on HDFS-8133:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12724970/HDFS-8133.patch
against trunk revision 174d8b3.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.TestDFSClientRetries
org.apache.hadoop.hdfs.server.namenode.TestProcessCorruptBlocks
org.apache.hadoop.hdfs.server.namenode.TestStorageRestore
Test results:
https://builds.apache.org/job/PreCommit-HDFS-Build/10262//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HDFS-Build/10262//console
This message is automatically generated.
> Improve readability of deleted block check
> ------------------------------------------
>
> Key: HDFS-8133
> URL: https://issues.apache.org/jira/browse/HDFS-8133
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Affects Versions: 2.0.0-alpha
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HDFS-8133.patch
>
>
> The current means of checking if a block is deleted is checking if its block
> collection is null. A more readable approach is an isDeleted method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
