[
https://issues.apache.org/jira/browse/HDFS-7859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493484#comment-14493484
]
Kai Zheng commented on HDFS-7859:
---------------------------------
Thanks [~xinwei] for the great work! Some comments or questions after a quick
look:
1. Looks like this couples with HDFS-7866. Maybe I could commit HDFS-7866 first
and then this gets all the left work done. Will it work for you this way?
2. I guess when reloading of predefined xml happens, some schemas need to be
updated/removed/added to editlog. What methods can ECSchemaManager call to make
it happen? I did notice some OPs like OP_REMOVE_EC_SCHEMA are added, but where
the OPs are triggered?
3. In {{ECSchemaManager}}, new methods like {{addECSchema}} are not necessarily
public.
4. A question would you help with, it's not clear to me when to call
{{loadECSchemas}} and when to call {{loadState}}. Are we supporting the two
formats? Please add Javadoc to explain them, thanks.
5. Would you have separate issue(s) for the following?
{code}
@Override
protected void toXml(ContentHandler contentHandler) throws SAXException {
// TODO Support for offline EditsVistor over an OEV XML file
}
@Override
void fromXml(Stanza st) throws InvalidXmlException {
// TODO Support for offline EditsVistor over an OEV XML file
}
{code}
> Erasure Coding: Persist EC schemas in NameNode
> ----------------------------------------------
>
> Key: HDFS-7859
> URL: https://issues.apache.org/jira/browse/HDFS-7859
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Xinwei Qin
> Attachments: HDFS-7859.001.patch
>
>
> In meetup discussion with [~zhz] and [~jingzhao], it's suggested that we
> persist EC schemas in NameNode centrally and reliably, so that EC zones can
> reference them by name efficiently.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
