[
https://issues.apache.org/jira/browse/HDFS-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493520#comment-14493520
]
Kai Zheng commented on HDFS-7349:
---------------------------------
Looks like all deps for this are resolved, so we could get this done? I'm
reading the patch. Some comments so far:
1. In {{DFSClient}}, ref. below codes.
{code}
public ECZoneInfo getEcZoneInfo(String src) throws IOException {
{code}
* A Javadoc for it, explaining the src parameter?
* Maybe getEcZoneInfo => getECZoneInfo?
* It's not consistent with {{DistributedFileSystem#getErasureCodingZoneInfo}},
please clean up.
* Along the route of it from client to NameNode in somewhere, we may need to
check any valid ECZoneInfo returned or not and guard the NPE error, because
it's very possible to be null for most files in a cluster.
> Support DFS command for the EC encoding
> ---------------------------------------
>
> Key: HDFS-7349
> URL: https://issues.apache.org/jira/browse/HDFS-7349
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Vinayakumar B
> Assignee: Vinayakumar B
> Attachments: HDFS-7349-001.patch, HDFS-7349-002.patch,
> HDFS-7349-003.patch, HDFS-7349-004.patch
>
>
> Support implementation of the following commands
> *hdfs dfs -convertToEC <path>*
> <path>: Converts all blocks under this path to EC form (if not already in
> EC form, and if can be coded).
> *hdfs dfs -convertToRep <path>*
> <path>: Converts all blocks under this path to be replicated form.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)