[ 
https://issues.apache.org/jira/browse/HDFS-7937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493558#comment-14493558
 ] 

Jing Zhao commented on HDFS-7937:
---------------------------------

Thanks for updating the patch, Kai! The new patch looks good to me. Some minors:
# We can directly initialize defaultSchema instead of using a {{setupCluster}} 
method.
# I just realized that our quota computation has a bug. Specifically, size of 
parity cells should be equal to the size of the first cell if the first cell is 
not full. Please see HDFS-8120 {{StripedBlockUtil#getInternalBlockLength}} for 
details. We can use this jira to fix this bug and update the unit test 
accordingly.


> Erasure Coding: INodeFile quota computation unit tests
> ------------------------------------------------------
>
>                 Key: HDFS-7937
>                 URL: https://issues.apache.org/jira/browse/HDFS-7937
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Kai Sasaki
>            Assignee: Kai Sasaki
>            Priority: Minor
>         Attachments: HDFS-7937.1.patch, HDFS-7937.2.patch, HDFS-7937.3.patch, 
> HDFS-7937.4.patch, HDFS-7937.5.patch, HDFS-7937.6.patch, HDFS-7937.7.patch
>
>
> Unit test for [HDFS-7826|https://issues.apache.org/jira/browse/HDFS-7826]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to