[
https://issues.apache.org/jira/browse/HDFS-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14493755#comment-14493755
]
Vinayakumar B commented on HDFS-7866:
-------------------------------------
Hi [~xinwei], Thanks for working on this.
Patch looks good.
Some nits.
1. namesystem is unused now. Let it be added whenever actually used.
{code}
+ /**
+ * The FSNamesystem that contains this ECSchemaManager.
+ */
+ private final FSNamesystem namesystem;{code}
2. can remove ): in the log message. I think you wanted to put sad smiley ( :(
) , but logger wont understand your feelings ;)
{code}
+ LOG.warn("A schema {} is updated but will be ignored as not " +
+ "supported yet):", schema.getSchemaName());{code}
3. Can also update TODO in the {{FSNameSystem#getECSchemas()}} to return loaded
schemas.
4. Rename {{TestSchemaManager}} to {{TestECSchemaManager}}
> Erasure coding: NameNode manages EC schemas
> -------------------------------------------
>
> Key: HDFS-7866
> URL: https://issues.apache.org/jira/browse/HDFS-7866
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Attachments: HDFS-7866-v1.patch, HDFS-7866-v2.patch
>
>
> This is to extend NameNode to load, list and sync predefine EC schemas in
> authorized and controlled approach. The provided facilities will be used to
> implement DFSAdmin commands so admin can list available EC schemas, then
> could choose some of them for target EC zones.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
