[
https://issues.apache.org/jira/browse/HDFS-8144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14495174#comment-14495174
]
Xiaoyu Yao commented on HDFS-8144:
----------------------------------
[~arpitagarwal], the patch looks pretty good to me. I just have two comments:
1. We don't need @Test (timeout=300000) for each test case because the base
class LazyPersistTestCase.java has already set timeout by Rule as follows.
{code}
@Rule
public Timeout timeout = new Timeout(300000);
{code}
2. Nit: Extra empty line at TestLazyWriter.java: 278
> Split TestLazyPersistFiles into multiple tests
> ----------------------------------------------
>
> Key: HDFS-8144
> URL: https://issues.apache.org/jira/browse/HDFS-8144
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
> Affects Versions: 2.7.0
> Reporter: Arpit Agarwal
> Assignee: Arpit Agarwal
> Attachments: HDFS-8144.01.patch
>
>
> TestLazyPersistFiles has grown too large and includes both NN and DN tests.
> We can split up related tests into smaller files to keep the test case
> manageable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
