[ 
https://issues.apache.org/jira/browse/HDFS-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498881#comment-14498881
 ] 

Zhe Zhang commented on HDFS-7994:
---------------------------------

Thanks Hui for the work and Nicholas for the review! This is a nice 
optimization. 

Sorry for the late comments. Below are some nits that we might want to address 
in a follow-on task:
# Seems to be a little weird to have a setter and a getter with the same name. 
Since the setter is only called with {{true}}, maybe {{foundxxx}} instead of 
{{hasxxx}}?

> Detect if resevered EC Block ID is already used
> -----------------------------------------------
>
>                 Key: HDFS-7994
>                 URL: https://issues.apache.org/jira/browse/HDFS-7994
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Hui Zheng
>             Fix For: HDFS-7285
>
>         Attachments: HDFS-7994_001.patch, HDFS-7994_002.patch
>
>
> Since random block IDs were supported by some early version of HDFS, the 
> block ID reserved for EC blocks could be already used by some existing blocks 
> in a cluster. During NameNode startup, it detects if there are reserved EC 
> block IDs used by non-EC blocks. If it is the case, NameNode will do an 
> additional blocksMap lookup when there is a miss in a blockGroupsMap lookup.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to