[
https://issues.apache.org/jira/browse/HDFS-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14499004#comment-14499004
]
Tsz Wo Nicholas Sze commented on HDFS-8167:
-------------------------------------------
> Seems to be a little weird to have a setter and a getter with the same name.
> ...
hasNonEcBlockUsingStripedID(true) is only used it in BlockManager. Let's
simply use "hasNonEcBlockUsingStripedID = true".
> Since we plan to support EC with non-striping layout in phase II, non-EC
> blocks should be "contiguous blocks". We can use an abbreviation of
> contiguous in naming
Let's change the name at that time. "hasNonEcBlockUsingStripedID" is
consistent with BlockIdManager.isStripedBlockID(..).
> ... block passed to addBlockCollectionWithCheck is a striped block ...
Good point. We should also check "!block.isStriped()".
> BlockManager.addBlockCollectionWithCheck should check if the block is a
> striped block
> -------------------------------------------------------------------------------------
>
> Key: HDFS-8167
> URL: https://issues.apache.org/jira/browse/HDFS-8167
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Hui Zheng
>
> This JIRA is to address [~zhz]'s
> [comment|https://issues.apache.org/jira/browse/HDFS-7994?focusedCommentId=14498894&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14498894].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
