[
https://issues.apache.org/jira/browse/HDFS-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909120#action_12909120
]
Konstantin Shvachko commented on HDFS-1363:
-------------------------------------------
The tests ran fine, except the usual suspects: TestTrash and
TestFileConcurrentReader.
test-patch complains there are no new tests included. I find it hard to
envision all possible ways of spliiting a synchronized section into two or more
sections making it hard to test. And the main functionality is tested well by
existing test cases.
{code}
. [exec] -1 overall.
[exec] +1 @author. The patch does not contain any @author tags.
[exec] -1 tests included. The patch doesn't appear to include any
new or modified test
[exec] Please justify why no new tests are needed
for this patch.
[exec] Also please list what manual steps were
performed to verify this patch.
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec] +1 javac. The applied patch does not increase the total
number of javac compiler warnings.
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
[exec] +1 system tests framework. The patch passed system tests
framework compile.
[exec]
======================================================================
{code}
> startFileInternal should return the last block of the file opened for append
> as an under-construction block
> -----------------------------------------------------------------------------------------------------------
>
> Key: HDFS-1363
> URL: https://issues.apache.org/jira/browse/HDFS-1363
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 0.21.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Fix For: 0.21.1
>
> Attachments: appendFileSync.patch, appendFileSync.patch
>
>
> {{FSNamesystem.startFileInternal}} should convert the last block of the file
> opened for append to an under-construction block and return it. This will let
> remove the second synchronized section in {{FSNamesystem.appendFile()}} and
> avoid redundant computations and potential inconsistencies as stated in
> HDFS-1152.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
