[
https://issues.apache.org/jira/browse/HDFS-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhe Zhang updated HDFS-8167:
----------------------------
Attachment: HDFS-8167_002.patch
The patch looks good to me. Just one nit that we should combine the if
conditions instead of using two {{if}}'s.
{code}
if (!hasNonEcBlockUsingStripedID && !block.isStriped() &&
BlockIdManager.isStripedBlockID(block.getBlockId())) {
hasNonEcBlockUsingStripedID = true;
}
{code}
I just made this trivial change and committed the patch. Thanks Hui and
Nicholas!
> BlockManager.addBlockCollectionWithCheck should check if the block is a
> striped block
> -------------------------------------------------------------------------------------
>
> Key: HDFS-8167
> URL: https://issues.apache.org/jira/browse/HDFS-8167
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: namenode
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Hui Zheng
> Attachments: HDFS-8167_001.patch, HDFS-8167_002.patch
>
>
> This JIRA is to address [~zhz]'s
> [comment|https://issues.apache.org/jira/browse/HDFS-7994?focusedCommentId=14498894&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14498894].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
