[
https://issues.apache.org/jira/browse/HDFS-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502619#comment-14502619
]
Kai Zheng commented on HDFS-8156:
---------------------------------
Hi [~szetszwo],
bq.Why do we need initWith? Could initWith be changed to a constructor and
change all the fields to final, i.e. making ECSchema immutable?
{{initWith}} is needed because the codes in it couldn't be in a constructor as
it needs to be called in the end of another constructor. It's already immutable
now even the fields are not final because no setting is allowed once
constructed.
bq.Could two schemas having the same name but different set of logical
parameters?
We should avoid such schemas in a system. Will update the document reflecting
this thought.
bq.Should two schemas having the same set of logical parameters but different
names be considered the same?
We should also avoid such schemas. Will update the document reflecting this
thought.
Maybe we can enhance {{ECSchema}} to add such comparision logics when we
support multiple schemas. For now I didn't change the codes.
Patch was updated for your other comments. Please help review one more time,
thanks a lot!
> Add/implement necessary APIs even we just have the system default schema
> ------------------------------------------------------------------------
>
> Key: HDFS-8156
> URL: https://issues.apache.org/jira/browse/HDFS-8156
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Kai Zheng
> Attachments: HDFS-8156-v1.patch, HDFS-8156-v2.patch,
> HDFS-8156-v3.patch, HDFS-8156-v4.patch, HDFS-8156-v5.patch
>
>
> According to the discussion here, this issue was repurposed and modified.
> This is to add and implement some necessary APIs even we just have the system
> default schema, to resolve some TODOs left for HDFS-7859 and HDFS-7866 as
> they're still subject to further discussion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
