[ 
https://issues.apache.org/jira/browse/HDFS-8200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14505416#comment-14505416
 ] 

Jing Zhao commented on HDFS-8200:
---------------------------------

The patch looks good to me. One minor is that we can also pass the 
INodeAttributes into {{createFileStatus(..., needLocation, ...)}} to make the 
style more consistent. +1 after addressing the comments.

> Refactor FSDirStatAndListingOp
> ------------------------------
>
>                 Key: HDFS-8200
>                 URL: https://issues.apache.org/jira/browse/HDFS-8200
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>         Attachments: HDFS-8200.000.patch
>
>
> After HDFS-6826 several functions in {{FSDirStatAndListingOp}} are dead. This 
> jira proposes to clean them up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to