[
https://issues.apache.org/jira/browse/HDFS-8218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506715#comment-14506715
]
Hadoop QA commented on HDFS-8218:
---------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 42s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:red}-1{color} | whitespace | 0m 0s | The patch has 42 line(s) that
end in whitespace. |
| {color:green}+1{color} | javac | 7m 45s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 43s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 5m 31s | The applied patch generated
20 additional checkstyle issues. |
| {color:green}+1{color} | install | 1m 35s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:red}-1{color} | findbugs | 3m 50s | The patch appears to introduce
16 new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | native | 3m 18s | Pre-build of native portion |
| {color:green}+1{color} | hdfs tests | 164m 21s | Tests passed in hadoop-hdfs.
|
| {color:green}+1{color} | hdfs tests | 0m 16s | Tests passed in
hadoop-hdfs-client. |
| | | 212m 1s | |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hadoop-hdfs-client |
| | org.apache.hadoop.fs.XAttr.getValue() may expose internal representation
by returning XAttr.value At XAttr.java:by returning XAttr.value At
XAttr.java:[line 112] |
| | org.apache.hadoop.fs.XAttr$Builder.setValue(byte[]) may expose internal
representation by storing an externally mutable object into XAttr$Builder.value
At XAttr.java:by storing an externally mutable object into XAttr$Builder.value
At XAttr.java:[line 88] |
| | org.apache.hadoop.hdfs.inotify.EventBatch.getEvents() may expose internal
representation by returning EventBatch.events At EventBatch.java:by returning
EventBatch.events At EventBatch.java:[line 40] |
| | new org.apache.hadoop.hdfs.inotify.EventBatch(long, Event[]) may expose
internal representation by storing an externally mutable object into
EventBatch.events At EventBatch.java:internal representation by storing an
externally mutable object into EventBatch.events At EventBatch.java:[line 33] |
| | org.apache.hadoop.hdfs.protocol.BlockStoragePolicy.getCreationFallbacks()
may expose internal representation by returning
BlockStoragePolicy.creationFallbacks At BlockStoragePolicy.java:by returning
BlockStoragePolicy.creationFallbacks At BlockStoragePolicy.java:[line 251] |
| |
org.apache.hadoop.hdfs.protocol.BlockStoragePolicy.getReplicationFallbacks()
may expose internal representation by returning
BlockStoragePolicy.replicationFallbacks At BlockStoragePolicy.java:by
returning BlockStoragePolicy.replicationFallbacks At
BlockStoragePolicy.java:[line 255] |
| | org.apache.hadoop.hdfs.protocol.BlockStoragePolicy.getStorageTypes() may
expose internal representation by returning BlockStoragePolicy.storageTypes At
BlockStoragePolicy.java:by returning BlockStoragePolicy.storageTypes At
BlockStoragePolicy.java:[line 247] |
| | new org.apache.hadoop.hdfs.protocol.BlockStoragePolicy(byte, String,
StorageType[], StorageType[], StorageType[], boolean) may expose internal
representation by storing an externally mutable object into
BlockStoragePolicy.creationFallbacks At BlockStoragePolicy.java:StorageType[],
boolean) may expose internal representation by storing an externally mutable
object into BlockStoragePolicy.creationFallbacks At
BlockStoragePolicy.java:[line 72] |
| | new org.apache.hadoop.hdfs.protocol.BlockStoragePolicy(byte, String,
StorageType[], StorageType[], StorageType[], boolean) may expose internal
representation by storing an externally mutable object into
BlockStoragePolicy.replicationFallbacks At
BlockStoragePolicy.java:StorageType[], boolean) may expose internal
representation by storing an externally mutable object into
BlockStoragePolicy.replicationFallbacks At BlockStoragePolicy.java:[line 73] |
| | new org.apache.hadoop.hdfs.protocol.BlockStoragePolicy(byte, String,
StorageType[], StorageType[], StorageType[], boolean) may expose internal
representation by storing an externally mutable object into
BlockStoragePolicy.storageTypes At BlockStoragePolicy.java:StorageType[],
boolean) may expose internal representation by storing an externally mutable
object into BlockStoragePolicy.storageTypes At BlockStoragePolicy.java:[line
71] |
| | org.apache.hadoop.hdfs.protocol.CorruptFileBlocks.getFiles() may expose
internal representation by returning CorruptFileBlocks.files At
CorruptFileBlocks.java:by returning CorruptFileBlocks.files At
CorruptFileBlocks.java:[line 44] |
| | new org.apache.hadoop.hdfs.protocol.CorruptFileBlocks(String[], String)
may expose internal representation by storing an externally mutable object into
CorruptFileBlocks.files At CorruptFileBlocks.java:internal representation by
storing an externally mutable object into CorruptFileBlocks.files At
CorruptFileBlocks.java:[line 39] |
| | org.apache.hadoop.hdfs.protocol.DirectoryListing.getPartialListing() may
expose internal representation by returning DirectoryListing.partialListing At
DirectoryListing.java:by returning DirectoryListing.partialListing At
DirectoryListing.java:[line 55] |
| | new org.apache.hadoop.hdfs.protocol.DirectoryListing(HdfsFileStatus[],
int) may expose internal representation by storing an externally mutable object
into DirectoryListing.partialListing At DirectoryListing.java:internal
representation by storing an externally mutable object into
DirectoryListing.partialListing At DirectoryListing.java:[line 46] |
| | new org.apache.hadoop.hdfs.security.token.block.DataEncryptionKey(int,
String, byte[], byte[], long, String) may expose internal representation by
storing an externally mutable object into DataEncryptionKey.encryptionKey At
DataEncryptionKey.java:long, String) may expose internal representation by
storing an externally mutable object into DataEncryptionKey.encryptionKey At
DataEncryptionKey.java:[line 40] |
| | new org.apache.hadoop.hdfs.security.token.block.DataEncryptionKey(int,
String, byte[], byte[], long, String) may expose internal representation by
storing an externally mutable object into DataEncryptionKey.nonce At
DataEncryptionKey.java:long, String) may expose internal representation by
storing an externally mutable object into DataEncryptionKey.nonce At
DataEncryptionKey.java:[line 39] |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12727133/HDFS-8218.000.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 6f8003d |
| whitespace |
https://builds.apache.org/job/PreCommit-HDFS-Build/10342/artifact/patchprocess/whitespace.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/10342/artifact/patchprocess/checkstyle-result-diff.txt
|
| Findbugs warnings |
https://builds.apache.org/job/PreCommit-HDFS-Build/10342/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs-client.html
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/10342/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| hadoop-hdfs-client test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/10342/artifact/patchprocess/testrun_hadoop-hdfs-client.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/10342/testReport/ |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/10342//console |
This message was automatically generated.
> Move classes that used by ClientProtocol into hdfs-client
> ---------------------------------------------------------
>
> Key: HDFS-8218
> URL: https://issues.apache.org/jira/browse/HDFS-8218
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: build
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HDFS-8218.000.patch
>
>
> {{ClientProtocol}} uses the following classes and all of them can be moved
> into the hdfs-client package without code changes:
> {noformat}
> hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/CacheFlag.java
>
> hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/fs/XAttr.java
> hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/inotify/Event.java
>
> hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/inotify/EventBatch.java
>
> hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/inotify/EventBatchList.java
>
> hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/AlreadyBeingCreatedException.java
>
> hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/BlockStoragePolicy.java
>
> hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/CorruptFileBlocks.java
>
> hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DSQuotaExceededException.java
>
> hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeLocalInfo.java
>
> hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/DirectoryListing.java
>
> hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/EncryptionZone.java
>
> hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/LastBlockWithStatus.java
>
> hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/NSQuotaExceededException.java
>
> hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/QuotaExceededException.java
>
> hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/RollingUpgradeInfo.java
>
> hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/RollingUpgradeStatus.java
>
> hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/SnapshotAccessControlException.java
>
> hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/security/token/block/DataEncryptionKey.java
> {noformat}
> This jira proposes to move them into the hdfs-client package.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
