[
https://issues.apache.org/jira/browse/HDFS-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507562#comment-14507562
]
Jing Zhao commented on HDFS-8176:
---------------------------------
Thanks for working on this, [~andreina]! The patch looks good to me overall.
Just one minor: currently the parameter {{fromSnapshot}}/{{toSnapshot}} can be
null or empty, which indicates the current path (i.e., the non-snapshot path).
Thus we need to check this case when computing the src/dst for audit log.
> Provide information about the snapshots compared in audit log
> -------------------------------------------------------------
>
> Key: HDFS-8176
> URL: https://issues.apache.org/jira/browse/HDFS-8176
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: J.Andreina
> Assignee: J.Andreina
> Attachments: HDFS-8176.1.patch
>
>
> Provide information about the snapshots compared in audit log.
> In current code value "null" is been passed.
> {code}
> logAuditEvent(diffs != null, "computeSnapshotDiff", null, null, null);
> {code}
> {noformat}
> 2015-04-15 09:56:49,328 INFO FSNamesystem.audit: allowed=true ugi=Rex
> (auth:SIMPLE) ip=/XXXXXXXXX cmd=computeSnapshotDiff src=null
> dst=null perm=null proto=rpc
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
