[
https://issues.apache.org/jira/browse/HDFS-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507882#comment-14507882
]
Andrew Wang commented on HDFS-8191:
-----------------------------------
Couple notes:
* Rather than adding another argument to addSomeBlocks, let's keep the one-arg
form of addSomeBlocks and have it default negativeBlocks to false. Have a
two-arg form just for testWriteRead.
I'm not very happy with this test in general. Not exactly related to this
change, but if you don't mind let's do a few small cleanups:
* Make addSomeBlocks and blockIdToLen static
* testWriteRead's "read" function, let's break it out into a new static
function "readSomeBlocks" and put it by addSomeBlocks. The logic is heavily
interlinked.
> Fix byte to integer casting in SimulatedFSDataset#simulatedByte
> ---------------------------------------------------------------
>
> Key: HDFS-8191
> URL: https://issues.apache.org/jira/browse/HDFS-8191
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Zhe Zhang
> Assignee: Zhe Zhang
> Priority: Minor
> Attachments: HDFS-8191.000.patch, HDFS-8191.001.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
