[ 
https://issues.apache.org/jira/browse/HDFS-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14508049#comment-14508049
 ] 

Colin Patrick McCabe commented on HDFS-8213:
--------------------------------------------

bq. Yes, clients need tracing, and when they do they should enable it 
themselves. FsShell should enable tracing when it wants to use it, instead of 
doing that in DFSClient.

There are hundreds or maybe even thousands of programs that use the HDFS 
client.  It's not practical to modify them all to run 
{{Trace#addSpanReceiver}}.  In some cases the programs that use HDFS are even 
proprietary or customer programs where we don't have access to the source code.

I have some ideas for how to make this all work better with a better interface 
in {{Tracer}}.  We might need an incompatible interface change to do it, 
though.  For now, let's just change the config key for DFSClient... that should 
fix the problem for Accumulo.

> DFSClient should not instantiate SpanReceiverHost
> -------------------------------------------------
>
>                 Key: HDFS-8213
>                 URL: https://issues.apache.org/jira/browse/HDFS-8213
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.7.0
>            Reporter: Billie Rinaldi
>            Assignee: Brahma Reddy Battula
>            Priority: Critical
>
> DFSClient initializing SpanReceivers is a problem for Accumulo, which manages 
> SpanReceivers through its own configuration.  This results in the same 
> receivers being registered multiple times and spans being delivered more than 
> once.  The documentation says SpanReceiverHost.getInstance should be issued 
> once per process, so there is no expectation that DFSClient should do this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to