[jira] [Commented] (HDFS-7281) Missing block is marked as corrupted block

[Yongjun Zhang (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HDFS-7281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510451#comment-14510451
 ] 

Yongjun Zhang commented on HDFS-7281:
-------------------------------------

Hi [~mingma],

Thanks for the new rev and sorry for being late. It looks good, only one 
comment here:

We may change:
{code}
      if (missing > 0) {
        out.print(" MISSING " + missing + " blocks of total size " + missize + 
" B\n");
      }
      if (corrupt > 0) {
        out.print(" CORRUPT " + corrupt + " blocks of total size " +
            corruptSize + " B\n");
      }
      if (underReplicatedPerFile == 0 && misReplicatedPerFile == 0) {
        out.print(" OK\n");
      }
{code}

to 

{code}
      if (missing > 0 || corrupt > 0) {
        if (missing > 0) {
          out.print(" MISSING " + missing + " blocks of total size " + missize 
+ " B\n");
        }
        if (corrupt > 0) {
          out.print(" CORRUPT " + corrupt + " blocks of total size " +
            corruptSize + " B\n");
        }
      } else if (underReplicatedPerFile == 0 && misReplicatedPerFile == 0) {
        out.print(" OK\n");
      }
{code}

such that if there are missing/corrupt blocks, we don't report OK. Right?

BTW, Would you please write a release notes about this fsck report change?

Thanks.



> Missing block is marked as corrupted block
> ------------------------------------------
>
>                 Key: HDFS-7281
>                 URL: https://issues.apache.org/jira/browse/HDFS-7281
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Ming Ma
>            Assignee: Ming Ma
>              Labels: supportability
>         Attachments: HDFS-7281-2.patch, HDFS-7281-3.patch, HDFS-7281-4.patch, 
> HDFS-7281.patch
>
>
> In the situation where the block lost all its replicas, fsck shows the block 
> is missing as well as corrupted. Perhaps it is better not to mark the block 
> corrupted in this case. The reason it is marked as corrupted is 
> numCorruptNodes == numNodes == 0 in the following code.
> {noformat}
> BlockManager
>     final boolean isCorrupt = numCorruptNodes == numNodes;
> {noformat}
> Would like to clarify if it is the intent to mark missing block as corrupted 
> or it is just a bug.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)