[
https://issues.apache.org/jira/browse/HDFS-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14510530#comment-14510530
]
Xiaoyu Yao commented on HDFS-8231:
----------------------------------
Thanks [~vinayrpet] for review the patch and providing detailed feedback.
bq. RemoteException#unwrapRemoteException(..) compares just the classnames not
instanceof..
I thought the same when started and soon found the same limitation of
unwrapRemoteException.
bq. Still I recommend to extend QuotaByStorageTypeExceededException from
DSQuotaExceededException and remove call to super.getMessage() in
QuotaByStorageTypeExceededException#toString() to get the correct message.
+1 for this and I will update the patch.
bq. QuotaByStorageTypeExceededException should be added to Terse exception list
to avoid traces at NameNode side. Changes to be done at NameNodeRPCServer
constructor at following point.
+1 for this and I will update the patch.
> StackTrace displayed at client while QuotaByStorageType exceeds
> ---------------------------------------------------------------
>
> Key: HDFS-8231
> URL: https://issues.apache.org/jira/browse/HDFS-8231
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: hdfs-client
> Reporter: J.Andreina
> Assignee: J.Andreina
> Priority: Minor
> Attachments: HDFS-8231.00.patch, HDFS-8231.1.patch
>
>
> StackTrace displayed at client while QuotaByStorageType exceeds.
> With reference to HDFS-2360, feel better to fix this issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
