[jira] [Commented] (HDFS-8242) Erasure Coding: XML based end-to-end test for ECCli commands

[Zhe Zhang (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HDFS-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513502#comment-14513502
 ] 

Zhe Zhang commented on HDFS-8242:
---------------------------------

Thanks Rakesh for the work! BePlease find my review below:

Logics:
# I'm not familiar with other CLI tests. Should we test things like illegal 
parameters here?
# Should we test creating a zone, create a file in the zone, and get EC info 
from that file (not that dir)?

Nits:
# Looks like this assert is unnecessary, as {{MiniDFSCluster#getFileSystem}} 
always returns {{DistributedFileSystem}}
{code}
 fs = dfsCluster.getFileSystem();
    assertTrue("Not a HDFS: " + fs.getUri(),
        fs instanceof DistributedFileSystem);
{code}
# What's the purpose of the following line?
{code
expCmd = expCmd.replaceAll("#LF#", System.getProperty("line.separator"));
{code}

> Erasure Coding: XML based end-to-end test for ECCli commands
> ------------------------------------------------------------
>
>                 Key: HDFS-8242
>                 URL: https://issues.apache.org/jira/browse/HDFS-8242
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>         Attachments: HDFS-8242-001.patch, HDFS-8242-002.patch
>
>
> This JIRA to add test cases with CLI test f/w for the commands present in 
> {{ECCli}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)