[
https://issues.apache.org/jira/browse/HDFS-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14514470#comment-14514470
]
Chris Nauroth commented on HDFS-8232:
-------------------------------------
Hi [~anu]. The patch looks great. I have just a few minor comments.
# There is a Java package named
{{org.apache.hadoop.hdfs.server.datanode.metrics}}. I think this is the
appropriate place for the new {{DataNodeMetricHelper}} class, so would you
please move it there?
# In the test, please name the method {{testFSDataSetMetrics}}. We always use
a lower-case first letter for method names.
I cannot repro the test failures from the last Jenkins run, and the code
changed in this patch is unrelated.
Thanks!
> Missing datanode counters when using Metrics2 sink interface
> ------------------------------------------------------------
>
> Key: HDFS-8232
> URL: https://issues.apache.org/jira/browse/HDFS-8232
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode
> Affects Versions: 2.7.1
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Attachments: hdfs-8232.001.patch
>
>
> When using the Metric2 Sink interface none of the counters declared under
> Dataanode:FSDataSetBean are visible. They are visible if you use JMX or if
> you do http://host:port/jmx.
> Expected behavior is that they be part of Sink interface and accessible in
> the putMetrics call back.
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
