[
https://issues.apache.org/jira/browse/HDFS-8235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14515833#comment-14515833
]
Jing Zhao commented on HDFS-8235:
---------------------------------
The 002 patch looks good to me. Some minors:
# We can add a "preconditions.checkArgument" or "assert" in
{{DFSStripedInputStream}} to make sure the ecinfo is not null
# In the test, we should use {{FileSystem#open}} to *replace* all the {{new
DFSStripedInputStream(...)}}. Thus we do not need to repeat the same tests in
{{TestDFSStripedInputStream}}.
# Also we can delete the constructor {{DFSStripedInputStream(DFSClient
dfsClient, String src, boolean verifyChecksum)}}.
> Create DFSStripedInputStream in DFSClient#open
> ----------------------------------------------
>
> Key: HDFS-8235
> URL: https://issues.apache.org/jira/browse/HDFS-8235
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Jing Zhao
> Assignee: Kai Sasaki
> Attachments: HDFS-8235.1.patch, HDFS-8235.2.patch
>
>
> Currently DFSClient#open can only create a DFSInputStream object. It should
> also support DFSStripedInputStream.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
