[
https://issues.apache.org/jira/browse/HDFS-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912778#action_12912778
]
Suresh Srinivas commented on HDFS-1407:
---------------------------------------
All the unit tests except TestHDFSTrash passed. Here is the ouput of testpatch:
[exec]
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 15 new or
modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
[exec]
[exec] +1 system tests framework. The patch passed system tests
framework compile.
> Use Block in DataTransferProtocol
> ---------------------------------
>
> Key: HDFS-1407
> URL: https://issues.apache.org/jira/browse/HDFS-1407
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.22.0
>
> Attachments: HDFS-1400.trunk.patch, HDFS-1400.trunk.patch
>
>
> Currently DataTransferProtocol has methods such as:
> {noformat}
> public static void opReadBlock(DataOutputStream out, long blockId,
> long blockGs, long blockOffset, long blockLen, String clientName,
> Token<BlockTokenIdentifier> blockToken) throws IOException;
> {noformat}
> The client has to pass the individual elements that make block identification
> such as blockId and generation stamp. I propose methods with the following
> format:
> {noformat}
> public static void opReadBlock(DataOutputStream out, Block block,
> long blockOffset, long blockLen, String clientName,
> Token<BlockTokenIdentifier> blockToken) throws IOException;
> {noformat}
> With this, the client need not understand the internals of Block. It receives
> Block over RPC and sends it in DataTransferProtocol. This helps in making
> Block opaque to the client.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
