[
https://issues.apache.org/jira/browse/HDFS-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518196#comment-14518196
]
Colin Patrick McCabe commented on HDFS-8213:
--------------------------------------------
bq. In SpanReceiverHost#getInstance, loadSpanReceivers is called even if there
is already initialized SRH instance. Is it intentional?
Hmm. Good point... we don't want to be calling this more than once. Let's
have a {{SpanReceiverHost}} for each config prefix. That's the easiest thing
to do. Long-term, I think we should have a new API that avoids the need for
all this boilerplate code in the client...
bq. We need to fix TraceUtils#wrapHadoopConf which always assumes that prefix
is "hadoop.htrace.".
fixed
bq. Should we add entry for hdfs.client.htrace.spanreceiver.classes to
hdfs-default.xml?
yeah
> DFSClient should use hdfs.client.htrace HTrace configuration prefix rather
> than hadoop.htrace
> ---------------------------------------------------------------------------------------------
>
> Key: HDFS-8213
> URL: https://issues.apache.org/jira/browse/HDFS-8213
> Project: Hadoop HDFS
> Issue Type: Bug
> Affects Versions: 2.7.0
> Reporter: Billie Rinaldi
> Assignee: Colin Patrick McCabe
> Priority: Critical
> Attachments: HDFS-8213.001.patch
>
>
> DFSClient initializing SpanReceivers is a problem for Accumulo, which manages
> SpanReceivers through its own configuration. This results in the same
> receivers being registered multiple times and spans being delivered more than
> once. The documentation says SpanReceiverHost.getInstance should be issued
> once per process, so there is no expectation that DFSClient should do this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
