[
https://issues.apache.org/jira/browse/HDFS-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913831#action_12913831
]
Tsz Wo (Nicholas), SZE commented on HDFS-1304:
----------------------------------------------
{noformat}
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 9 new or
modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning
messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number
of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs
warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the
total number of release audit warnings.
[exec]
[exec] +1 system tests framework. The patch passed system tests
framework compile.
[exec]
{noformat}
I also have run the new unit test. It works fine.
> There is no unit test for HftpFileSystem.open(..)
> -------------------------------------------------
>
> Key: HDFS-1304
> URL: https://issues.apache.org/jira/browse/HDFS-1304
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: test
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: h1304_20100921.patch, h1304_20100922.patch
>
>
> HftpFileSystem.open(..) first opens an URL connection to namenode's
> FileDataServlet and then is redirected to datanode's StreamFile servlet.
> Such redirection does not work in the unit test environment because the
> redirect URL uses real hostname instead of localhost.
> One way to get around it is to use fault-injection in order to replace the
> real hostname with localhost.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
