[
https://issues.apache.org/jira/browse/HDFS-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lei (Eddy) Xu updated HDFS-7758:
--------------------------------
Attachment: HDFS-7758.007.patch
Hi, [~cmccabe] Thanks for the review!
bq. So let's change ReferredFsVolumes -> FsVolumeReferences
Done
bq. if we change FsVolumeReference -> FsVolumeReference<? extends FsVolumeSpi>
and FsVolumeReferences -> FsVolumeReferences<? extends FsVolumeSpi>
Sure. I will do a follow on JIRA.
bq. FsDatasetImpl#volumes is still package-private rather than truly private.
{{FsDatasetImpl#volumes}} is a {{FsVolumeList}} object, which does not leak
{{FsVolumeImpl}} by itself. Moreover, {{TestWriteToReplica}} is using it. So it
is still need to be package level field. I removed {{private
FsDatasetImplgetVolumes()}} function, which exposed
{{FsVolumeList#getVolumes()}}.
Would you mind to do another review? Thanks!
> Retire FsDatasetSpi#getVolumes() and use FsDatasetSpi#getVolumeRefs() instead
> -----------------------------------------------------------------------------
>
> Key: HDFS-7758
> URL: https://issues.apache.org/jira/browse/HDFS-7758
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: datanode
> Affects Versions: 2.6.0
> Reporter: Lei (Eddy) Xu
> Assignee: Lei (Eddy) Xu
> Attachments: HDFS-7758.000.patch, HDFS-7758.001.patch,
> HDFS-7758.002.patch, HDFS-7758.003.patch, HDFS-7758.004.patch,
> HDFS-7758.005.patch, HDFS-7758.006.patch, HDFS-7758.007.patch
>
>
> HDFS-7496 introduced reference-counting the volume instances being used to
> prevent race condition when hot swapping a volume.
> However, {{FsDatasetSpi#getVolumes()}} can still leak the volume instance
> without increasing its reference count. In this JIRA, we retire the
> {{FsDatasetSpi#getVolumes()}} and propose {{FsDatasetSpi#getVolumeRefs()}}
> and etc. method to access {{FsVolume}}. Thus it makes sure that the consumer
> of {{FsVolume}} always has correct reference count.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
