[
https://issues.apache.org/jira/browse/HDFS-3488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14524606#comment-14524606
]
Hadoop QA commented on HDFS-3488:
---------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | patch | 0m 0s | The patch command could not apply
the patch during dryrun. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12574374/HDFS-3488.001.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / f1a152c |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/10534/console |
This message was automatically generated.
> BlockPoolSliceScanner#getNewBlockScanTime does not handle numbers > 31 bits
> properly
> ------------------------------------------------------------------------------------
>
> Key: HDFS-3488
> URL: https://issues.apache.org/jira/browse/HDFS-3488
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HDFS-3488.001.patch
>
>
> This code does not handle the case where period > 2**31 properly:
> {code}
> long period = Math.min(scanPeriod,
> Math.max(blockMap.size(),1) * 600 * 1000L);
> int periodInt = Math.abs((int)period);
> return System.currentTimeMillis() - scanPeriod +
> DFSUtil.getRandom().nextInt(periodInt);
> {code}
> So, for example, if period = 0x100000000, we'll map that to 0, and so forth.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
