[ 
https://issues.apache.org/jira/browse/HDFS-8284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529094#comment-14529094
 ] 

Colin Patrick McCabe commented on HDFS-8284:
--------------------------------------------

Thanks, [~iwasakims].  This looks really good.

The only thing I would suggest is that we should remove the section or two on 
zipkin stuff.  Instead, we should link to the upstream HTrace documentation 
about setting up span receivers.  Having it in there makes people think that 
the only way to use htrace is through zipkin, which is certainly not true.

> Add usage of tracing originated in DFSClient to doc
> ---------------------------------------------------
>
>                 Key: HDFS-8284
>                 URL: https://issues.apache.org/jira/browse/HDFS-8284
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Masatake Iwasaki
>            Assignee: Masatake Iwasaki
>         Attachments: HDFS-8284.001.patch, HDFS-8284.002.patch
>
>
> Tracing originated in DFSClient uses configuration keys prefixed with 
> "dfs.client.htrace" after HDFS-8213. Server side tracing uses conf keys 
> prefixed with "dfs.htrace".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to