[ 
https://issues.apache.org/jira/browse/HDFS-8255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhe Zhang updated HDFS-8255:
----------------------------
    Attachment: HDFS-8255.001.patch

Thanks Andrew for the comment. Yes we do want to support striping + replication 
in the future. In that case, {{getPreferredBlockReplication}} can still 
represent the repl factor of each internal block, while a new value can 
represent the preferred _level of redundancy_.

Let's just use this JIRA to rename {{getBlockReplication}} to 
{{getPreferredBlockReplication}} then. I will add {{getPreferredRedundancy}} 
under HDFS-8010 (it doesn't make much sense to add it without EC).

> Rename getBlockReplication to getPreferredBlockStorageNum
> ---------------------------------------------------------
>
>                 Key: HDFS-8255
>                 URL: https://issues.apache.org/jira/browse/HDFS-8255
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Zhe Zhang
>            Assignee: Zhe Zhang
>         Attachments: HDFS-8255.000.patch, HDFS-8255.001.patch
>
>
> We should rename {{BlockCollection#getBlockReplication}} to 
> {{getPreferredBlockStorageNum}} for 2 reasons:
> # Currently, this method actually returns the _preferred_ block replication 
> factor instead of the _actual_ number of replicas. The current name is a 
> little ambiguous. {{getPreferredBlockStorageNum}} is also consistent with 
> {{getPreferredBlockSize}}
> # With the erasure coding feature, the name doesn't apply to striped blocks. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to