[
https://issues.apache.org/jira/browse/HDFS-8255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14529559#comment-14529559
]
Hadoop QA commented on HDFS-8255:
---------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 31s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 4 new or modified test files. |
| {color:green}+1{color} | javac | 7m 28s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 30s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 2m 10s | The applied patch generated 1
new checkstyle issues (total was 844, now 845). |
| {color:green}+1{color} | whitespace | 0m 2s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 3m 4s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | native | 3m 14s | Pre-build of native portion |
| {color:green}+1{color} | hdfs tests | 166m 38s | Tests passed in hadoop-hdfs.
|
| | | 209m 12s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12730588/HDFS-8255.001.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / ffce9a3 |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/10820/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/10820/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/10820/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/10820/console |
This message was automatically generated.
> Rename getBlockReplication to getPreferredBlockStorageNum
> ---------------------------------------------------------
>
> Key: HDFS-8255
> URL: https://issues.apache.org/jira/browse/HDFS-8255
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 2.8.0
> Reporter: Zhe Zhang
> Assignee: Zhe Zhang
> Attachments: HDFS-8255.000.patch, HDFS-8255.001.patch
>
>
> We should rename {{BlockCollection#getBlockReplication}} to
> {{getPreferredBlockStorageNum}} for 2 reasons:
> # Currently, this method actually returns the _preferred_ block replication
> factor instead of the _actual_ number of replicas. The current name is a
> little ambiguous. {{getPreferredBlockStorageNum}} is also consistent with
> {{getPreferredBlockSize}}
> # With the erasure coding feature, the name doesn't apply to striped blocks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
