[
https://issues.apache.org/jira/browse/HDFS-6757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533475#comment-14533475
]
Haohui Mai commented on HDFS-6757:
----------------------------------
Thanks Jing for the reviews. The v14 patch addresses all comments except 7 and
11.
{quote}
7. One question is, after we record INode id in lease manager, do we still want
to record full paths of UC files in FSImage?
{quote}
It's a good proposal. This has been discussed in this jira
(https://issues.apache.org/jira/browse/HDFS-6757?focusedCommentId=14094487&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14094487).
I prefer to addressing it in a separate jira since we don't have the consensus
yet.
{quote}
11. Maybe we can add extra tests for the delete and rename operations when UC
files are involved. Specifically, a test on the internal lease recovery for
renamed UC files may be useful.
{quote}
It looks like that {{TestLease}} has covered this case.
> Simplify lease manager with INodeID
> -----------------------------------
>
> Key: HDFS-6757
> URL: https://issues.apache.org/jira/browse/HDFS-6757
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Labels: BB2015-05-TBR
> Attachments: HDFS-6757.000.patch, HDFS-6757.001.patch,
> HDFS-6757.002.patch, HDFS-6757.003.patch, HDFS-6757.004.patch,
> HDFS-6757.005.patch, HDFS-6757.006.patch, HDFS-6757.007.patch,
> HDFS-6757.008.patch, HDFS-6757.009.patch, HDFS-6757.010.patch,
> HDFS-6757.011.patch, HDFS-6757.012.patch, HDFS-6757.013.patch,
> HDFS-6757.014.patch
>
>
> Currently the lease manager records leases based on path instead of inode
> ids. Therefore, the lease manager needs to carefully keep track of the path
> of active leases during renames and deletes. This can be a non-trivial task.
> This jira proposes to simplify the logic by tracking leases using inodeids
> instead of paths.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
