[
https://issues.apache.org/jira/browse/HDFS-8062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533868#comment-14533868
]
Kai Sasaki commented on HDFS-8062:
----------------------------------
[~drankye] Sorry for late update. I submit a new patch. Can you review it?
{quote}
5. I'm wondering about the following change, regarding the else part. Maybe
just throw error exception?.
{quote}
I think there is a case when striped block has an empty block group. Taking it
into consideration, there is no need to throw exception as an error. In
addition to this, because {{INodeFile}} inherits {{BlockCollection}}, there are
a lot of dependencies through override methods. If we throw exception here, it
will require changes other override methods and super class methods to handle
it.
> Remove hard-coded values in favor of EC schema
> ----------------------------------------------
>
> Key: HDFS-8062
> URL: https://issues.apache.org/jira/browse/HDFS-8062
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Kai Zheng
> Assignee: Kai Sasaki
> Attachments: HDFS-8062.1.patch, HDFS-8062.2.patch, HDFS-8062.3.patch,
> HDFS-8062.4.patch, HDFS-8062.5.patch, HDFS-8062.6.patch
>
>
> Related issues about EC schema in NameNode side:
> HDFS-7859 is to change fsimage and editlog in NameNode to persist EC schemas;
> HDFS-7866 is to manage EC schemas in NameNode, loading, syncing between
> persisted ones in image and predefined ones in XML.
> This is to revisit all the places in NameNode that uses hard-coded values in
> favor of {{ECSchema}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
