[ 
https://issues.apache.org/jira/browse/HDFS-8296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14534372#comment-14534372
 ] 

Vinayakumar B commented on HDFS-8296:
-------------------------------------

I think, in the namenode's safemode block stats will not be correct because all 
block reports might not have updated.
So IMO this is not a problem.

>  BlockManager.getUnderReplicatedBlocksCount() is not giving correct count if 
> namenode in safe mode.
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-8296
>                 URL: https://issues.apache.org/jira/browse/HDFS-8296
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.6.0
>            Reporter: surendra singh lilhore
>            Assignee: surendra singh lilhore
>              Labels: BB2015-05-RFC
>         Attachments: HDFS-8296.patch
>
>
> {{underReplicatedBlocksCount}} update by the {{updateState()}} API.
> {code}
>  void updateState() {
>     pendingReplicationBlocksCount = pendingReplications.size();
>     underReplicatedBlocksCount = neededReplications.size();
>     corruptReplicaBlocksCount = corruptReplicas.size();
>   }
>  {code}
>  but this will not call when NN in safe mode. This is happening because 
> "computeDatanodeWork()" we will return 0 if NN in safe mode 
>  {code}
>   int computeDatanodeWork() {
>    .........
>     if (namesystem.isInSafeMode()) {
>       return 0;
>     }
>     ....................
>     ....................
>     this.updateState();
>     ....................
>     ....................
>   }
>  {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to