[
https://issues.apache.org/jira/browse/HDFS-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14536169#comment-14536169
]
Rakesh R commented on HDFS-6300:
--------------------------------
Thanks [~szetszwo] for the review comments.
bq. The real fix is "fs.create(idPath, false);". The new
checkAnotherBalancerIsRunning() method is for fail-fast. Some minor comments.
Yes. I hope you are agreeing to keep this check in my logic.
bq. For the test, the first Balancer may finish and exist before the second
balancer start.
Awsome. This will make it very simple. I'll modify this as per your suggestion
bq. Could you not renaming out to fsout in checkAndMarkRunning().
I renamed because checkstyle is complaining like,
{code}
./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/balancer/NameNodeConnector.java:250:28:
'out' hides a field.
{code}
Does this change makes sense?
> Shouldn't allows to run multiple balancer simultaneously
> --------------------------------------------------------
>
> Key: HDFS-6300
> URL: https://issues.apache.org/jira/browse/HDFS-6300
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: balancer & mover
> Reporter: Rakesh R
> Assignee: Rakesh R
> Labels: BB2015-05-RFC
> Attachments: HDFS-6300-001.patch, HDFS-6300-002.patch,
> HDFS-6300-003.patch, HDFS-6300.patch
>
>
> Javadoc of "Balancer.java" says, it will not allow to run second balancer if
> the first one is in progress. But I've noticed multiple can run together and
> balancer.id implementation is not safe guarding.
> {code}
> * <li>Another balancer is running. Exiting...
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
