[
https://issues.apache.org/jira/browse/HDFS-8364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539458#comment-14539458
]
Vinayakumar B edited comment on HDFS-8364 at 5/12/15 7:48 AM:
--------------------------------------------------------------
Good catches [~walter.k.su].
+1 for patch changes.
It would be better to add some tests related to this in
{{TestErasureCodingCLI.java}}
was (Author: vinayrpet):
Good catches [~walter.k.su].
+1 for patch.
> Erasure coding: fix some minor bugs in EC CLI
> ---------------------------------------------
>
> Key: HDFS-8364
> URL: https://issues.apache.org/jira/browse/HDFS-8364
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Walter Su
> Assignee: Walter Su
> Priority: Minor
> Attachments: HDFS-8364-HDFS-7285.001.patch
>
>
> issue 1: it's not user-friendly. We should tell user that `hdfs
> erasurecode` is the entrance to EC commands(HDFS-7349)
> {noformat}
> # bin/hdfs
> Usage: hdfs [--config confdir] [--daemon (start|stop|status)]
> [--loglevel loglevel] COMMAND
> where COMMAND is one of:
> balancer run a cluster balancing utility
> cacheadmin configure the HDFS cache
> crypto configure HDFS encryption zones
> ...
> zkfc run the ZK Failover Controller daemon
> {noformat}
> issue 2: it's not user-friendly
> {noformat}
> # bin/hdfs erasurecode -getZoneInfo /
> -getZoneInfo: Fatal internal error
> java.lang.NullPointerException
> at
> org.apache.hadoop.hdfs.tools.erasurecode.ECCommand$GetECZoneInfoCommand.processPath(ECCommand.java:168)
> at org.apache.hadoop.fs.shell.Command.processPaths(Command.java:321)
> at
> org.apache.hadoop.fs.shell.Command.processPathArgument(Command.java:293)
> at
> org.apache.hadoop.fs.shell.Command.processArgument(Command.java:275)
> at
> org.apache.hadoop.fs.shell.Command.processArguments(Command.java:259)
> at
> org.apache.hadoop.fs.shell.Command.processRawArguments(Command.java:205)
> at org.apache.hadoop.fs.shell.Command.run(Command.java:166)
> at org.apache.hadoop.fs.FsShell.run(FsShell.java:291)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
> at org.apache.hadoop.hdfs.tools.erasurecode.ECCli.main(ECCli.java:45)
> {noformat}
> possible issue 3: We create zone twice at /
> {noformat}
> # bin/hdfs erasurecode -createZone /
> EC Zone created successfully at hdfs://ds-34:9000/
> # bin/hdfs erasurecode -createZone /
> createZone: Unable to create EC zone for the path hdfs://ds-34:9000/
> {noformat}
> It doesn't print detail error message.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
