[
https://issues.apache.org/jira/browse/HDFS-6184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539531#comment-14539531
]
Akira AJISAKA commented on HDFS-6184:
-------------------------------------
Copied from
https://builds.apache.org/job/PreCommit-HDFS-Build/10857/artifact/patchprocess/commentfile
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 40s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 2 new or modified test files. |
| {color:green}+1{color} | javac | 7m 28s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 41s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 2m 35s | The applied patch generated
1232 new checkstyle issues (total was 1904, now 1492). |
| {color:red}-1{color} | whitespace | 0m 13s | The patch has 6 line(s) that
end in whitespace. Use git apply --whitespace=fix. |
| {color:green}+1{color} | install | 1m 35s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 34s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 4m 44s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | common tests | 22m 48s | Tests passed in
hadoop-common. |
| {color:red}-1{color} | hdfs tests | 166m 12s | Tests failed in hadoop-hdfs. |
| | | 230m 57s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests | hadoop.tracing.TestTraceAdmin |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12731358/HDFS-6184-4.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / f33efbc |
| checkstyle |
https://builds.apache.org/job/PreCommit-HDFS-Build/10857/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HDFS-Build/10857/artifact/patchprocess/whitespace.txt
|
| hadoop-common test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/10857/artifact/patchprocess/testrun_hadoop-common.txt
|
| hadoop-hdfs test log |
https://builds.apache.org/job/PreCommit-HDFS-Build/10857/artifact/patchprocess/testrun_hadoop-hdfs.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HDFS-Build/10857/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-HDFS-Build/10857/console |
This message was automatically generated.
> Capture NN's thread dump when it fails over
> -------------------------------------------
>
> Key: HDFS-6184
> URL: https://issues.apache.org/jira/browse/HDFS-6184
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: Ming Ma
> Assignee: Ming Ma
> Attachments: HDFS-6184-2.patch, HDFS-6184-3.patch, HDFS-6184-4.patch,
> HDFS-6184.patch
>
>
> We have seen several false positives in terms of when ZKFC considers NN to be
> unhealthy. Some of these triggers unnecessary failover. Examples,
> 1. SBN checkpoint caused ZKFC's RPC call into NN timeout. The consequence
> isn't bad; just that SBN will quit ZK membership and rejoin it later. But it
> is unnecessary. The reason is checkpoint acquires NN global write lock and
> all rpc requests are blocked. Even though HAServiceProtocol.monitorHealth
> doesn't need to acquire NN lock; it still needs to user service rpc queue.
> 2. When ANN is busy, sometimes the global lock can block other requests.
> ZKFC's RPC call timeout. This will trigger failover. The question is even if
> after the failover, the new ANN might run into similar issue.
> We can increase ZKFC to NN timeout value to mitigate this to some degree. If
> ZKFC can be more accurate in judgment if NN is health or not and can predict
> the failover will help, that will be useful. For example, we can,
> 1. Have ZKFC made decision based on NN thread dump.
> 2. Have a dedicated rpc pool for ZKFC > NN. Given health check doesn't need
> to acquire NN global lock; so it can go through even if NN is doing
> checkpointing or very busy.
> Any comments?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
