[ 
https://issues.apache.org/jira/browse/HDFS-4383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539543#comment-14539543
 ] 

Arshad Mohammad commented on HDFS-4383:
---------------------------------------

{quote}
{color:red}-1{color}     |  tests included |  0m 0s |  The patch doesn't appear 
to include any new or modified tests. Please justify why no new tests are 
needed for this patch. Also please list what manual steps were performed to 
verify this patch.
{quote}
Only java doc is added, no functionality got added/modified. So no test cases

{quote}
{color:red}-1{color}     |  hdfs tests |  164m 53s |  Tests failed in 
hadoop-hdfs..
{quote}
Test case failure are surely not because of this patch. This patch is only 
added java doc, there is not funtionality changes

> Document the lease limits
> -------------------------
>
>                 Key: HDFS-4383
>                 URL: https://issues.apache.org/jira/browse/HDFS-4383
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Eli Collins
>            Assignee: Arshad Mohammad
>            Priority: Trivial
>              Labels: BB2015-05-RFC
>         Attachments: HDFS-4383-5.patch, HDFS-4383-6.patch, HDFS-4383.3.patch, 
> HDFS-4383.patch, HDFS-4383.patch, HDFS-4383.patch
>
>
> HdfsConstants.java or DFSClient/LeaseManager.java could use a comment 
> indicating the behavior of hard and soft file lease limit periods.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to